[ci] Retry dump participant identities. #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry logic to a test that was experiencing flaky failures by wrapping the dumpParticipantIdentities() call in an eventually() block. This addresses intermittent CI test failures documented in issue #1054.
- Adds retry mechanism to the "dump participant identities" test case to handle transient failures
Comments suppressed due to low confidence (1)
apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/runbook/ValidatorPreflightIntegrationTest.scala:402
- The eventually() block should include timeout and interval parameters to make the retry behavior predictable and avoid indefinite waiting. Consider adding explicit timeout configuration like
eventually(timeout(30.seconds), interval(1.second)).
eventually() {
nicu-da
reviewed
Jul 18, 2025
Contributor
There was a problem hiding this comment.
you probs want eventuallySucceeds
Contributor
Author
There was a problem hiding this comment.
ah thanks
Signed-off-by: Raymond Roestenburg <[email protected]>
ray-roestenburg-da
force-pushed
the
ray/retry_dump/cntf/1054
branch
from
9bdbead to
f99c67f
Compare
nicu-da
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DACH-NY/cn-test-failures/issues/1054
More info also in https://github.com/DACH-NY/cn-test-failures/issues/5027 where it shows that istio temporarily returns
503Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines